Add feature backtrace - #526
Open
target-san wants to merge 29 commits into
Open
Conversation
rexmas
reviewed
Oct 29, 2025
| /// | ||
| /// This is constructed via `.into()` on a `String`, `&'static str`, or | ||
| /// `Box<str>`. | ||
| #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] |
Member
There was a problem hiding this comment.
Would removal of these traits not be considered public API breaking? It would seem so to me since any client reliant on the methods of the removed traits would no longer work.
(Sorry for getting back to this so late, thank you for your patience 🙇)
Contributor
Author
There was a problem hiding this comment.
These had to be implemented manually below - because Backtrace can't implement them, except Debug which would be just too verbose. Please check lines 83+ and 165+.
rexmas
reviewed
Oct 29, 2025
| # Transitive dependency of `insta`, v0.15.10 requires MSRV 1.66 | ||
| console = "=0.15.8" | ||
| # Transitive dependency of `insta`, v0.1.14+ requires some features unstable on Rust 1.65 | ||
| unicode-width = "=0.1.13" |
Member
There was a problem hiding this comment.
the MSRV is much higher now so this may need to be adjusted
Contributor
Author
|
Sorry, won't be able to check this until end of next week. And I'll need to recheck it - it's been a year since I posted this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables collection of full backtraces:
handle-panicsfeature is enabledprop_assertmacro or any of its derivatives is used