docs(tooltip): align previews with design system#121
Open
joshsadam wants to merge 7 commits into
Open
Conversation
This reverts commit 3d27339.
Replace gradient-heavy Lookbook pages with compact product surfaces that match Button and Typography previews. Drop implementation-detail pages and keep overview, in-context, accessibility, and the click-through regression check.
Icon-only tooltip examples now pass accessible names via aria-label and clarify that tooltips supplement, not replace, those names.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Pathogen Tooltip Lookbook previews to better match the design-system “product-like” preview guidelines by replacing large, marketing-style pages with a smaller set of focused, realistic examples.
Changes:
- Replaces the previous Tooltip preview pages (basic usage, advanced features, browser compatibility, link integration) with compact “Overview” and “In context” previews.
- Refines existing previews to use neutral surfaces/tokens and tighter product-like layouts (including the click-through visual regression preview).
- Streamlines Tooltip preview grouping/labels in
TooltipPreviewto match the new preview set.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/components/previews/pathogen/tooltip_preview/overview.html.erb | New compact “Overview” preview covering placement, text length, and toolbar-style examples. |
| test/components/previews/pathogen/tooltip_preview/in_context.html.erb | New “In context” preview showing icon-only actions, collapsed nav, and breadcrumbs in product-like shells. |
| test/components/previews/pathogen/tooltip_preview/click_through_after_hide.html.erb | Restyles the click-through regression preview to match neutral design-system surfaces while keeping the repro behavior. |
| test/components/previews/pathogen/tooltip_preview/accessibility.html.erb | Replaces the old long-form accessibility page with focused “Accessibility patterns” examples (hover/focus, ARIA wiring, keyboard). |
| test/components/previews/pathogen/tooltip_preview.rb | Updates preview group and labels to reflect the new reduced preview set. |
| test/components/previews/pathogen/tooltip_preview/link_integration.html.erb | Removes the old large “Link integration” page. |
| test/components/previews/pathogen/tooltip_preview/browser_compatibility.html.erb | Removes the old large “Browser compatibility” page. |
| test/components/previews/pathogen/tooltip_preview/basic_usage.html.erb | Removes the old large “Basic usage” page. |
| test/components/previews/pathogen/tooltip_preview/advanced_features.html.erb | Removes the old large “Advanced features” page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Use inspect so placement examples show valid Ruby like :top instead of bare top.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Part of #99.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
pnpm run lintPR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.