Skip to content

fix: safe weight parsing to prevent ValueError and remove redundant typecasts (#804) #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhaniiz wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: safe weight parsing to prevent ValueError and remove redundant typecasts (#804) #811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions backend/app/rag/graph_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,15 @@ def get_entity_context(
"pages": set(),
},
)
existing["weight"] = int(existing["weight"]) + int(edge.get("weight", 1))
# Safely extract the raw weight, defaulting to 1 if missing or invalid
raw_weight = edge.get("weight", 1)
try:
# Convert to float first to handle decimals safely, then round/truncate if needed
weight_value = int(float(raw_weight)) if raw_weight is not None else 1
except (ValueError, TypeError):
weight_value = 1

existing["weight"] += weight_value
existing["pages"].update(edge.get("pages", []))
except Exception as exc:
logger.warning("GraphRAG context retrieval failed: %s", exc)
Expand All @@ -105,9 +113,10 @@ def get_entity_context(
if not relationships:
return ""

# Clean sorting without redundant typecasting overhead
ranked = sorted(
relationships.values(),
key=lambda item: int(item["weight"]),
key=lambda item: item["weight"],
reverse=True,
)[: settings.GRAPH_MAX_RELATIONSHIPS]

Expand Down
Loading