fix: safe weight parsing to prevent ValueError and remove redundant typecasts (#804)#811
Open
suhaniiz wants to merge 1 commit into
Open
Conversation
|
@suhaniiz is attempting to deploy a commit to the param20h's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 PR Checklist
🔗 Related Issue
Closes #804
📝 What does this PR do?
This PR resolves an inconsistent and fragile weight accumulation pattern inside
get_entity_contextthat left the graph pipeline vulnerable to unexpected crashes.Changes introduced:
int(edge.get("weight", 1))assignment with a robust parsing pattern (int(float(raw_weight))) wrapped inside a structuredtry-exceptblock. This safely handles float inputs, float strings (e.g.,"2.5"), or arbitrary missing properties without raising aValueErrororTypeError.+=operator on the safely handled scalar.int()typecasting overhead from the finalsorted()key lambda loop, as dictionary weight properties are now guaranteed numerical entities.🗂️ Type of Change
🧪 How was this tested?
uvicorn app.main:app --reload)📸 Screenshots (if UI change)
N/A
The defensive
try-exceptfallback assumes a standard default weight value of1if an unparseable data variant appears inside the knowledge graph attributes, keeping context generation intact without bringing down the core RAG server.✅ Self-Review Checklist
dev, notmainmainbranch or any HuggingFace deployment config