Do not use -latomic on macOS

[kojix2]

This pull request is to avoid specifying -latomic on macOS.

• Building Seqwish on macOS #117

I refer to the following pull request.

• pangenome/odgi@33fc8ca

[ekg]

I can't test this. Does it work?

…

On Tue, Nov 14, 2023 at 11:12 PM kojix2 ***@***.***> wrote: This pull request is to avoid specifying -latomic on macOS. - #117 <#117> I refer to the following pull request. - ***@***.*** <pangenome/odgi@33fc8ca> ------------------------------ You can view, comment on, or merge this pull request online at: #119 Commit Summary - db94155 <db94155> Do not use -latomic on macOS File Changes (1 file <https://github.com/ekg/seqwish/pull/119/files>) - *M* CMakeLists.txt <https://github.com/ekg/seqwish/pull/119/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a> (2) Patch Links: - https://github.com/ekg/seqwish/pull/119.patch - https://github.com/ekg/seqwish/pull/119.diff — Reply to this email directly, view it on GitHub <#119>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABDQEJY3CSRDLK7JWARQHDYERFLJAVCNFSM6AAAAAA7L47AHGVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TIMBWGAYTGNA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[kojix2]

# add the "-latomic" option only if the system name is not "Darwin.
$<$<NOT:$<STREQUAL:${CMAKE_SYSTEM_NAME},Darwin>>:-latomic>

It works on my Mac mini.
There are no errors related to -latomic.
Although, this code was suggested by ChatGPT, after all...

[AndreaGuarracino]

Thanks for this. seqwish has since been rewritten in Rust and the C++ build moved under cpp/, so this patch no longer applies to CMakeLists.txt at the repo root and can't merge. The macOS -latomic fix is still valid for the legacy C++ build; if you still use it, it can be re-applied to cpp/CMakeLists.txt. Closing this one as obsolete against the current layout.