test: run shared suites with each sync adapter

tests/AbuseTest.php → tests/AbuseTestCase.php

@@ -13,10 +13,9 @@
 
 use InvalidArgumentException;
 use Overblog\DataLoader\DataLoader;
-use React\Promise\Promise;
 use RuntimeException;
 
-class AbuseTest extends TestCase
+abstract class AbuseTestCase extends TestCase
 {
     /**
      * @group provides-descriptive-error-messages-for-api-abuse
@@ -34,7 +33,7 @@ public function testLoadFunctionRequiresAKeyNotNull()
      */
     public function testLoadFunctionRequiresAKeyWith0()
     {
-        self::assertInstanceOf(Promise::class, self::idLoader()->load(0));
+        self::assertTrue(self::$promiseAdapter->isPromise(self::idLoader()->load(0), true));
     }
 
     /**
@@ -53,7 +52,7 @@ public function testLoadManyFunctionRequiresAListOfKey()
      */
     public function testLoadManyFunctionRequiresAListEmptyArrayAccepted()
     {
-        self::assertInstanceOf(Promise::class, self::idLoader()->loadMany([]));
+        self::assertTrue(self::$promiseAdapter->isPromise(self::idLoader()->loadMany([]), true));
     }
 
     /**

tests/DataLoadTest.php → tests/DataLoadTestCase.php

@@ -15,7 +15,7 @@
 use Overblog\DataLoader\DataLoader;
 use Overblog\DataLoader\Option;
 
-class DataLoadTest extends TestCase
+abstract class DataLoadTestCase extends TestCase
 {
     /**
      * @group primary-api
@@ -306,7 +306,7 @@ public function testCanRepresentFailuresAndSuccessesSimultaneously()
         $promise1->then(null, function ($error) use (&$caughtError) {
             $caughtError = $error;
         });
-        DataLoader::await();
+        DataLoader::await($promise1, false);
         $this->assertInstanceOf(\Exception::class, $caughtError);
         $this->assertEquals($caughtError->getMessage(), 'Odd: 1');
 
@@ -815,50 +815,6 @@ public function testAwaitAlsoAwaitsNewlyCreatedDataloaders()
         $this->assertTrue($secondComplete);
     }
 
-    /**
-     * @runInSeparateProcess
-     */
-    public function testAwaitShouldReturnTheValueOfFulfilledPromiseWithoutNeedingActiveDataLoaderInstance()
-    {
-        $expectedValue = 'Ok!';
-        $value = DataLoader::await(self::$promiseAdapter->createFulfilled($expectedValue));
-
-        $this->assertEquals($expectedValue, $value);
-    }
-
-    /**
-     * @runInSeparateProcess
-     */
-    public function testAwaitShouldReturnTheRejectReasonOfRejectedPromiseWithoutNeedingActiveDataLoaderInstance()
-    {
-        $expectedException = new \Exception('Rejected!');
-        $exception = DataLoader::await(self::$promiseAdapter->createRejected($expectedException), false);
-
-        $this->assertEquals($expectedException, $exception);
-    }
-
-    /**
-     * @runInSeparateProcess
-     */
-    public function testAwaitShouldThrowTheRejectReasonOfRejectedPromiseWithoutNeedingActiveDataLoaderInstance()
-    {
-        $this->expectException(\Exception::class);
-        $this->expectExceptionMessage('Rejected!');
-
-        DataLoader::await(self::$promiseAdapter->createRejected(new Exception('Rejected!')));
-    }
-
-    /**
-     * @runInSeparateProcess
-     */
-    public function testAwaitShouldThrowThrowable()
-    {
-        $this->expectException(\Error::class);
-        $this->expectExceptionMessage('Rejected Error!');
-
-        DataLoader::await(self::$promiseAdapter->createRejected(new \Error('Rejected Error!')));
-    }
-
     public function cacheKey($key)
     {
         $cacheKey = [];
@@ -914,6 +870,7 @@ private static function idLoader(?Option $options = null, ?callable $batchLoadFn
 
     private function assertInstanceOfPromise($object)
     {
-        $this->assertTrue(self::$promiseAdapter->isPromise($object, true));
+        $adapter = self::$promiseAdapter;
+        $this->assertTrue($adapter->isPromise($object, true));
     }
 }

tests/ReactAbuseTest.php

@@ -0,0 +1,23 @@
+<?php
+
+/*
+ * This file is part of the DataLoaderPhp package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Overblog\DataLoader\Test;
+
+use Overblog\PromiseAdapter\Adapter\ReactPromiseAdapter;
+use Overblog\PromiseAdapter\PromiseAdapterInterface;
+
+final class ReactAbuseTest extends AbuseTestCase
+{
+    protected function createPromiseAdapter(): PromiseAdapterInterface
+    {
+        return new ReactPromiseAdapter();
+    }
+}

tests/ReactDataLoadTest.php

@@ -0,0 +1,68 @@
+<?php
+
+/*
+ * This file is part of the DataLoaderPhp package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Overblog\DataLoader\Test;
+
+use Overblog\DataLoader\DataLoader;
+use Overblog\PromiseAdapter\Adapter\ReactPromiseAdapter;
+use Overblog\PromiseAdapter\PromiseAdapterInterface;
+
+final class ReactDataLoadTest extends DataLoadTestCase
+{
+    protected function createPromiseAdapter(): PromiseAdapterInterface
+    {
+        return new ReactPromiseAdapter();
+    }
+
+    /**
+     * @runInSeparateProcess
+     */
+    public function testAwaitShouldReturnTheValueOfFulfilledPromiseWithoutNeedingActiveDataLoaderInstance()
+    {
+        $expectedValue = 'Ok!';
+        $value = DataLoader::await(self::$promiseAdapter->createFulfilled($expectedValue));
+
+        $this->assertEquals($expectedValue, $value);
+    }
+
+    /**
+     * @runInSeparateProcess
+     */
+    public function testAwaitShouldReturnTheRejectReasonOfRejectedPromiseWithoutNeedingActiveDataLoaderInstance()
+    {
+        $expectedException = new \Exception('Rejected!');
+        $exception = DataLoader::await(self::$promiseAdapter->createRejected($expectedException), false);
+
+        $this->assertEquals($expectedException, $exception);
+    }
+
+    /**
+     * @runInSeparateProcess
+     */
+    public function testAwaitShouldThrowTheRejectReasonOfRejectedPromiseWithoutNeedingActiveDataLoaderInstance()
+    {
+        $this->expectException(\Exception::class);
+        $this->expectExceptionMessage('Rejected!');
+
+        DataLoader::await(self::$promiseAdapter->createRejected(new \Exception('Rejected!')));
+    }
+
+    /**
+     * @runInSeparateProcess
+     */
+    public function testAwaitShouldThrowThrowable()
+    {
+        $this->expectException(\Error::class);
+        $this->expectExceptionMessage('Rejected Error!');
+
+        DataLoader::await(self::$promiseAdapter->createRejected(new \Error('Rejected Error!')));
+    }
+}

tests/TestCase.php

@@ -11,7 +11,7 @@
 
 namespace Overblog\DataLoader\Test;
 
-use Overblog\PromiseAdapter\Adapter\ReactPromiseAdapter;
+use Overblog\DataLoader\DataLoader;
 use Overblog\PromiseAdapter\PromiseAdapterInterface;
 
 abstract class TestCase extends \PHPUnit\Framework\TestCase
@@ -23,6 +23,16 @@ abstract class TestCase extends \PHPUnit\Framework\TestCase
 
     public function setUp(): void
     {
-        self::$promiseAdapter = new ReactPromiseAdapter();
+        self::$promiseAdapter = $this->createPromiseAdapter();
     }
+
+    protected function tearDown(): void
+    {
+        $instances = new \ReflectionProperty(DataLoader::class, 'instances');
+        $instances->setValue([]);
+
+        parent::tearDown();
+    }
+
+    abstract protected function createPromiseAdapter(): PromiseAdapterInterface;
 }

tests/WebonyxAbuseTest.php

@@ -0,0 +1,23 @@
+<?php
+
+/*
+ * This file is part of the DataLoaderPhp package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Overblog\DataLoader\Test;
+
+use Overblog\PromiseAdapter\Adapter\WebonyxGraphQLSyncPromiseAdapter;
+use Overblog\PromiseAdapter\PromiseAdapterInterface;
+
+final class WebonyxAbuseTest extends AbuseTestCase
+{
+    protected function createPromiseAdapter(): PromiseAdapterInterface
+    {
+        return new WebonyxGraphQLSyncPromiseAdapter();
+    }
+}

tests/WebonyxDataLoadTest.php

@@ -0,0 +1,23 @@
+<?php
+
+/*
+ * This file is part of the DataLoaderPhp package.
+ *
+ * (c) Overblog <http://github.com/overblog/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Overblog\DataLoader\Test;
+
+use Overblog\PromiseAdapter\Adapter\WebonyxGraphQLSyncPromiseAdapter;
+use Overblog\PromiseAdapter\PromiseAdapterInterface;
+
+final class WebonyxDataLoadTest extends DataLoadTestCase
+{
+    protected function createPromiseAdapter(): PromiseAdapterInterface
+    {
+        return new WebonyxGraphQLSyncPromiseAdapter();
+    }
+}