test: run shared suites with each sync adapter - #80
Merged
Conversation
Keep the shared DataLoader behavior tests in one abstract suite and run them through explicit React and Webonyx test classes. Reset retained DataLoader instances between cases so adapter-specific state cannot leak across the matrix.
mcg-web
approved these changes
Aug 18, 2026
Contributor
|
Thank you @simPod ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*TestCasesuites and concrete adapter suites final.Motivation
The main behavior suites only exercised the React adapter. Running the shared contract through each synchronous adapter exposes adapter-specific behavior without duplicating test cases.