Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

ComputationResources Controller Refactor with Integration Testing for OpenTSDB#318

Merged
adamkorynta merged 9 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_computation_resources_it
Jan 30, 2025
Merged

ComputationResources Controller Refactor with Integration Testing for OpenTSDB#318
adamkorynta merged 9 commits into
opendcs:feature/task_cwms_supportfrom
zack-rma:feature/task_cwms_support_computation_resources_it

Conversation

@zack-rma

@zack-rma zack-rma commented Jan 7, 2025

Copy link
Copy Markdown
Collaborator

Problem Description

Fixes #234.

Solution

Implements Integration Testing coverage for ComputationResources Controller refactor.

how you tested the change

Integration tests run against REST API using OpenTSDB.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma zack-rma force-pushed the feature/task_cwms_support_computation_resources_it branch from 5332add to a8469b2 Compare January 7, 2025 21:06
@zack-rma zack-rma changed the title Feature/task cwms support computation resources it ComputationResources Integration Testing for OpenTSDB Jan 8, 2025
@zack-rma

Copy link
Copy Markdown
Collaborator Author

OpenDCS Toolkit method implementations can be found here: adamkorynta/opendcs#4

@zack-rma zack-rma changed the title ComputationResources Integration Testing for OpenTSDB ComputationResources Controller Refactor with Integration Testing for OpenTSDB Jan 10, 2025
@zack-rma

Copy link
Copy Markdown
Collaborator Author

Bug in progress: Looking at expanding tests to include a DataTypeId value, currently known to cause tests to fail when supplied.

@zack-rma zack-rma self-assigned this Jan 16, 2025
@zack-rma zack-rma marked this pull request as ready for review January 17, 2025 19:26
@zack-rma zack-rma requested a review from rma-rripken January 17, 2025 19:26
@zack-rma zack-rma requested a review from adamkorynta January 29, 2025 18:23
@zack-rma zack-rma force-pushed the feature/task_cwms_support_computation_resources_it branch from 60394a3 to d5e1021 Compare January 30, 2025 22:54
@sonarqubecloud

Copy link
Copy Markdown

@adamkorynta adamkorynta merged commit 6aef8a1 into opendcs:feature/task_cwms_support Jan 30, 2025
@zack-rma zack-rma removed their assignment Jan 31, 2025
adamkorynta pushed a commit that referenced this pull request Mar 13, 2025
… OpenTSDB (#318)

Implemented ComputationResources Controller refactor
adamkorynta pushed a commit that referenced this pull request Mar 24, 2025
… OpenTSDB (#318)

Implemented ComputationResources Controller refactor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

OpenTSDB: Create Integration Tests for ComputationResources controller Refactor ComputationResources controller

2 participants