This repository was archived by the owner on Apr 1, 2026. It is now read-only.
Refactor ComputationResources Controller#281
Closed
zack-rma wants to merge 3 commits into
Closed
Conversation
6 tasks
Collaborator
Author
|
Will need a new DAI method implementation in OpenDCS to complete this task |
zack-rma
force-pushed
the
feature/task_cwms_support_computation_resources
branch
from
8e30a4d to
6174141
Compare
|
Collaborator
Author
|
OpenDCS Toolkit method implementations can be found here: adamkorynta/opendcs#4 |
Collaborator
Author
|
Closing due to newer PR containing these changes and integration tests: #318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #221.
Solution
Replaces DAO usage with OpenDCS DAI implementations.
how you tested the change
Unit testing for data mapping included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.