This repository was archived by the owner on Apr 1, 2026. It is now read-only.
PlatformResources Controller Refactor with Integration Testing for OpenTSDB#312
Merged
adamkorynta merged 8 commits intoFeb 3, 2025
Conversation
zack-rma
added this to the
F0215 Task 2.2 - OpenTSDB: Integration Testing Controllers milestone
zack-rma
force-pushed
the
feature/task_cwms_support_platform_resources_it
branch
from
e4419b0 to
dd0a7e4
Compare
Collaborator
Author
|
Requires method implementations in Toolkit that can be found here: adamkorynta/opendcs#7 |
Collaborator
Author
|
Retrieval bug under investigation. Unable to retrieve stored data, objects come back with a valid DBKey but no other data populated. NetlistResources is currently experiencing the same bug, it is unclear if they are related. |
zack-rma
changed the title
6 tasks
Collaborator
Author
|
Bugs cleared up, requires changes in Toolkit including changes to testing harness. |
adamkorynta
suggested changes
Jan 29, 2025
zack-rma
force-pushed
the
feature/task_cwms_support_platform_resources_it
branch
2 times, most recently
from
976db78 to
0dba73e
Compare
This was
linked to
issues
Jan 31, 2025
This was referenced Jan 31, 2025
zack-rma
force-pushed
the
feature/task_cwms_support_platform_resources_it
branch
from
0dba73e to
be17a24
Compare
zack-rma
force-pushed
the
feature/task_cwms_support_platform_resources_it
branch
from
be17a24 to
7666abd
Compare
adamkorynta
suggested changes
Jan 31, 2025
| ret.setAgency(platform.getAgency()); | ||
| ret.setDescription(platform.getDescription()); | ||
| ret.setPlatformDesignator(platform.getDesignator()); | ||
| ret.lastModifyTime = Objects.requireNonNull(platform.getLastModified()); |
Contributor
There was a problem hiding this comment.
This will throw a null pointer exception, which is an error code 500 internal error rather than specifying a client error. I don't see the pre-existing logic performing this validation. In the old dao, the last modified is getting set to current and then returned to the client.
Collaborator
Author
There was a problem hiding this comment.
I reverted it to use the current date. This field was causing a silent exception within the Toolkit when null. I'll likely make a PR with a fix for that next week.
adamkorynta
approved these changes
Feb 3, 2025
|
adamkorynta
approved these changes
Feb 3, 2025
adamkorynta
pushed a commit
that referenced
this pull request
Mar 13, 2025
…enTSDB (#312) Refactored PlatformResources Controller, added OpenTSDB integration testing
adamkorynta
pushed a commit
that referenced
this pull request
Mar 24, 2025
…enTSDB (#312) Refactored PlatformResources Controller, added OpenTSDB integration testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #240.
Solution
Implements integration testing against OpenTSDB.
how you tested the change
Integration testing included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.