Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Feature/netlist cwms impl#331

Merged
adamkorynta merged 3 commits into
feature/task_cwms_supportfrom
feature/netlist_cwms_impl
Feb 4, 2025
Merged

Feature/netlist cwms impl#331
adamkorynta merged 3 commits into
feature/task_cwms_supportfrom
feature/netlist_cwms_impl

Conversation

@adamkorynta

Copy link
Copy Markdown
Contributor

Problem Description

Fixes #295.

The NetlistResources endpoints need coverage against CWMS.

Solution

Turn on integration tests for CWMS.

how you tested the change

Automated integration testing.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@adamkorynta

Copy link
Copy Markdown
Contributor Author

Currently blocked by: #312

@adamkorynta adamkorynta changed the base branch from main to feature/task_cwms_support January 31, 2025 17:01
@adamkorynta adamkorynta force-pushed the feature/netlist_cwms_impl branch from b6cbaa8 to 3d635d1 Compare February 3, 2025 23:39
@adamkorynta adamkorynta force-pushed the feature/netlist_cwms_impl branch from 3d635d1 to 439a320 Compare February 4, 2025 00:17
@adamkorynta adamkorynta marked this pull request as ready for review February 4, 2025 00:24
@adamkorynta adamkorynta requested a review from zack-rma February 4, 2025 00:33

@zack-rma zack-rma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting change, otherwise looks good.

ObjectMapper mapper = new ObjectMapper();

siteId = storeSite("netlist_site_insert_data.json");
siteId = storeSite("netlist_site_insert_data.json");String configJson = getJsonFromResource("config_input_data.json");

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be two lines

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@adamkorynta adamkorynta merged commit aab74e0 into feature/task_cwms_support Feb 4, 2025
@adamkorynta adamkorynta deleted the feature/netlist_cwms_impl branch February 4, 2025 00:38
@sonarqubecloud

sonarqubecloud Bot commented Feb 4, 2025

Copy link
Copy Markdown

adamkorynta added a commit that referenced this pull request Mar 13, 2025
implement netlist integration tests for cwms
adamkorynta added a commit that referenced this pull request Mar 24, 2025
implement netlist integration tests for cwms
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

CWMS: Create Integration Tests for NetlistResouces controller

2 participants