This repository was archived by the owner on Apr 1, 2026. It is now read-only.
Refactor DatatypeUnitResources Controller#279
Closed
zack-rma wants to merge 4 commits into
Closed
Conversation
6 tasks
Collaborator
Author
|
Some methods will need to be implemented in OpenDCS to complete this task |
|
rma-rripken
reviewed
Jan 2, 2025
rma-rripken
reviewed
Jan 2, 2025
rma-rripken
approved these changes
Jan 2, 2025
rma-rripken
suggested changes
Jan 2, 2025
rma-rripken
left a comment
rma-rripken
left a comment
Collaborator
There was a problem hiding this comment.
resolve the comments.
Collaborator
Author
|
OpenDCS Toolkit changes can be found here: adamkorynta/opendcs#2 Deletion bug and Toolkit support for UnitConverter deletion on XML DB in progress. |
rma-rripken
reviewed
Jan 3, 2025
Collaborator
Author
|
Closing due to newer PR with these changes and OpenTSDB integration testing: #315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #224.
Solution
Replaces DAO usage with OpenDCS DAI implementations.
how you tested the change
Unit tests included.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.