This repository was archived by the owner on Apr 1, 2026. It is now read-only.
Issue 224: DatatypeUnitResources Controller Updated to use OpenDCS DAOs#256
Closed
zack-rma wants to merge 18 commits into
Closed
Conversation
Collaborator
Author
|
Relies on changes found here: adamkorynta/opendcs#1 |
13fb594 to
fae06ab
Compare
fae06ab to
39adcb1
Compare
Relies on uncomment of delete method in UnitConverterIO of OpenDCS
d023953 to
ce3141f
Compare
Collaborator
Author
|
New PR: #279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Fixes #224.
Solution
Refactors controller to use OpenDCS data access implementations.
how you tested the change
Unit test added.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.