Skip to content

feat(taskbar): add minimal style option for workspace labels#3075

Open
joao-paulo-santos wants to merge 1 commit into
noctalia-dev:mainfrom
joao-paulo-santos:feat/taskbar-minimal-workspace-labels
Open

feat(taskbar): add minimal style option for workspace labels#3075
joao-paulo-santos wants to merge 1 commit into
noctalia-dev:mainfrom
joao-paulo-santos:feat/taskbar-minimal-workspace-labels

Conversation

@joao-paulo-santos

@joao-paulo-santos joao-paulo-santos commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds a minimal setting to the taskbar widget. When enabled, workspace labels render as colored text without the colored disc background, using the workspace fill color (primary for active, secondary for occupied) as the text color.

Motivation

This mirrors the minimal style option already available in the workspaces widget, providing visual consistency between the two workspace-related widgets. Some users prefer the cleaner look of text-only workspace labels without a filled disc background.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Related Issue

N/A.

Testing

  • ninja -C build clean build
  • python3 tools/i18n-check.py passes
  • clang-format --dry-run --Werror passes
  • Tested on Hyprland. Verified workspace disc labels show as colored text without background when enabled, and revert to normal styling when disabled.

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Screenshots / Videos

Off:
taskbar-minimal-before

On:
taskbar-minimal-after

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I will update end-user documentation after merge, or this PR does not change user-facing configuration or behavior.
  • I added or updated assets/translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.
  • I used the existing canonical names for config keys, IPC names, paths, and identifiers.

Additional Notes

Config example:

[widget.taskbar]
minimal = true

Three changes in taskbar_widget.cpp:

  • styleWorkspaceDisc: sets transparent fill instead of workspace fill color when minimal is on
  • Inline badge text color: uses workspaceFillColor instead of workspaceTextColor when minimal is on
  • External badge text color: same swap

No structural changes to the rendering pipeline. The disc Box remains in the scene graph but is transparent, keeping layout and hit-testing unchanged. The setting is visible in the taskbar widget settings when "Show Workspace Label" is enabled.

@joao-paulo-santos joao-paulo-santos force-pushed the feat/taskbar-minimal-workspace-labels branch 3 times, most recently from 8637cef to 6e585d0 Compare June 24, 2026 02:32
When enabled, workspace labels in the taskbar show as colored text
without the colored disc background. The fill color (primary for
active, secondary for occupied) becomes the text color instead.

This mirrors the minimal style option already available in the
workspaces widget.
@joao-paulo-santos joao-paulo-santos force-pushed the feat/taskbar-minimal-workspace-labels branch from 6e585d0 to 8b59c9a Compare June 24, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant