Moving using up/down keys - second try - #134
Open
Pac72 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @variar, did you spot this new pull request? Any comments? |
xhargh
referenced
this pull request
in xhargh/klogg-io
Jun 30, 2020
|
Implemented in: https://github.com/nekromoff/neoglogg |
Author
|
Never give up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows moving in AbstractLogView subclasses using key up and key down, keeping log file selection in sync with the search pane even when moving with the keyboard.