Skip to content

Moving using up/down keys - #94

Closed
Pac72 wants to merge 46 commits into
nickbnf:masterfrom
Pac72:master
Closed

Moving using up/down keys #94
Pac72 wants to merge 46 commits into
nickbnf:masterfrom
Pac72:master

Conversation

@Pac72

@Pac72 Pac72 commented Sep 4, 2015

Copy link
Copy Markdown

These changes:

  • allow moving in AbstractLogView subclasses using key up and key down
  • keep log file in sync with the search pane even when moving with the keyboard

@Pac72

Pac72 commented Dec 13, 2015

Copy link
Copy Markdown
Author

Hi @nickbnf, any comment on this pull request?

variar added 27 commits March 9, 2016 22:17
@variar
Make options dialog layout friendly to window resize
b99c494
@variar
Make general tab default one
35b21a3
@variar
Use atomic operations to set interrupt and terminate flags
1a2fec1
@variar
Fix indentation
7916896
@variar
Add option to not load last session
3b10469
@variar
Use file settings in programm dir before system specific settings places
5f5b86a
@variar
Merge branch 'load_last_session_option' into dev
47a22ef
@variar
Merge branch 'portable' into dev
f9fe502
@variar
Make native file watching optional via CONFIG qmake variable
0f8328b
@variar
Add missing includes
07557af
@variar
Use Qt atomic for portability (mingw without pthreads case)
d29d1a9
@variar
Use QString for filenames
1d82537
@variar
Fix view_context to QString formatting
a79e227
@variar
Fix some compiler warnings
26adf4b
@variar
Allow to get git version in shadow builds
955c213
@variar
Allow multiple files in qt-based file watcher
22f22cf
@variar
Restore selected line in filter view after new search
3bf7dbb
@variar
Keep selected line when switching filtered view visibility
43a7b9e
@variar
Use lower_bound in case there is no exact match for line number
e1d543d
@variar
Make marks selection lookup logarithmic
340cd8d
@variar
Add ignore case option to filters
b9c9a81
@variar
Update README
999dff6
@variar
Merge branch 'case_insensitive_filter'
e02bd1b
@variar
Switch from deprecated QRegExp to QRegularExpression
14b5111
@variar
Use Qt threading and mutex for portability
bdb4b9e
@variar
Allow to limit file search area
3eee570
@variar
Fix search limits selection
893faa0 
Signed-off-by: Anton Filimonov <anton.filimonov@gmail.com>
variar and others added 17 commits April 18, 2016 15:31
@variar
Make quicksearch hotkeys more numpad friendly
6541409
@variar
Use local socket base implementation of external communicator on windows
0852d82
@variar
Fix pro
a13b386
@variar
Merge with upstream v1.1.0
39d98e3 
Signed-off-by: Anton Filimonov <anton.filimonov@gmail.com>
@variar
Add support for multibyte utf encoding auto detection
16be497
@variar
Override auto-detected encoding from menu
0610721
@variar
Fix build
5f2cbf2
@variar
Fix setting foreground window on Win32
bca3f86
@variar
Add one more line to vertical scroll area
b1ff2a9
@Pac72
Implement a more natural behaviour for Key_Up and Key_Down
c724453
@Pac72
Emit newSelection() signal when changing selection with the keyboard
7fc76d9
@Pac72
Merge upstream changes.
7c390b8
@Pac72
Implement a more natural behaviour for Key_Up and Key_Down
1c88db9
@Pac72
Emit newSelection() signal when changing selection with the keyboard
4310c4b
@Pac72
Fix compilation with Qt 5.2.1
dc8eec0
@Pac72
Merge branch 'master' of github.com:Pac72/glogg
fe9bc1c
@Pac72
If file cannot be opened, clear indexing_data. Otherwise, if the file
d9128d2 
becomes openable/readable again, its indexing data will be appended to
the old one.
@variar

variar commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

As it is now this pull request is easier to apply to my branch. I suggest adapting changes to glogg/master branch, because it seems that a lot of proposed chages are irrelevant to the subject (moving with up/down keys).

@Pac72

Pac72 commented Dec 4, 2016

Copy link
Copy Markdown
Author

Could it be because the pull request is exactly 15 month old? ;-)
I'll have a look at it.

@Pac72

Pac72 commented Dec 4, 2016

Copy link
Copy Markdown
Author

@variar, I'm closing this one in favor of the new pull request #134, which applies cleanly on upstream/master

@Pac72 Pac72 closed this Dec 4, 2016
gin-ahirsch pushed a commit to gin-ahirsch/glogg that referenced this pull request Sep 23, 2019
@variar
Move session dependent settings to separate file (nickbnf#94)
fe9dbac
gin-ahirsch pushed a commit to gin-ahirsch/glogg that referenced this pull request Sep 23, 2019
@variar
Cleanup settings after files split (nickbnf#94)
1d0990d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pac72 @variar