Repository navigation
Conversation
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The generic
whileanalysis treated zero and single countdowns as if another iteration could run, and trusted a cancellation check after repeated iterations reset its flag. The bounded countdown proof handles the supported loop exactly.The review also found that each sibling helper rescanned the entire Effect. Cache the pure result for the actual scope analysis, Program and Effect identity so repeated queries reuse that scan.
What changed
Test plan
This PR remains draft pending integration of the updated ancestor fixes, final composed-source checks, public performance profiles and remote parity. Earlier performance flags remain unresolved.