Repository navigation
Conversation
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
no-set-state-after-await-in-effectflattenedwhilebodies. It warned on cancellation checks after eachawaitand missed writes reached after an earlier iteration suspended.The review also found repeated traversal of nested loops and scalar writes. Reuse pure Program facts and supported-subtree facts, then memoize flow results by the full analysis inputs and node identities.
What changed
The single-countdown false warning discovered in this PR is corrected by #2203. The previously documented erased-eval and outer-cancellation-reset controls retain their original results; this repair receives no fix credit for them.
Test plan
js-set-map-lookupswarning incollectCleanupFunctionsAfterInvocations. The entire function and reporting rule are byte-identical before this PR, in the published PR and after the repair. No suppression was added./checkendpoint with HTTP 404 after its automatic retries; no workflow rerun was requested.This PR remains draft pending integration of the updated ancestor fixes, final composed-source checks, public performance profiles and remote parity. Earlier performance flags remain unresolved.