Skip to content

FPFNFIXAPEX clean unused Chart fixture parameters - #2113

Open
aidenybai wants to merge 1 commit into
codex/fpfn-chart-options-state-role-84adfrom
codex/fpfn-unused-chart-fixture-parameters-5db
Open

aidenybai wants to merge 1 commit into
codex/fpfn-chart-options-state-role-84adfrom
codex/fpfn-unused-chart-fixture-parameters-5db

Conversation

@aidenybai

@aidenybai aidenybai commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Seven Chart regression fixtures bind an unused darkMode parameter. Rename the local binding to darkMode: _darkMode, preserving the input property name and its evaluation. This changes seven synthetic fixture lines on top of #2110; detector behavior and fixture expectations stay unchanged.

Validation at commit 65efacb6824f834023668a2d66bd73f1fe6ccb41:

  • Fresh uncached complete local checks pass: 34,247 tests passed / 1,118 skipped, 12 test tasks, 10 typecheck tasks, five build tasks, lint, format check, registry freshness and JSON-report smoke check. The earlier 176 focused tests across seven modules are adopted with source and runtime checks; they are separate from this fresh complete run.
  • Lint removes the seven unused-parameter warnings. There are 25 remaining warnings in these seven synthetic fixtures, plus three in other fixtures owned by the parent change, and zero warnings in owned production code. Remaining binding-collision fixtures retain their test purpose.
  • One normal tracked commit-hook invocation completed with seven static Chart import advisories under an unknown React profile. This is qualified advisory evidence, without target-activation credit.
  • Fresh repository sample against exact parent 5db34b9cca8cfe958802cf2d8f57135deb202fe9: 20 project roots / six repositories / 1,721 analyzed files; 3,308 whole diagnostics unchanged, zero added, zero removed, zero skipped roots. Full ordered diagnostic arrays, project configuration hashes, analyzed-file lists and report fields match except elapsed time. Independent review confirmed the saved results. This is sample evidence; full-corpus parity and performance remain unverified.

The sample evaluator and comparison both exited successfully. The outer wrapper stopped at its final PR-state guard after readiness changed externally; subsequent readbacks showed the same code head and base with the PR now non-draft. The original blocked wrapper outcome is preserved, and fixed-revision measurements are accepted separately. The failing readback payload was not retained, so no claim is made about unrecorded transient remote state. No sample rerun or readiness action was performed by this validation.

Keep #2110 before this PR. The current exact-head reported checks are successful; this does not assert main-only workflows ran on this stacked base. No changeset is needed for this private fixture cleanup.

@pkg-pr-new

pkg-pr-new Bot commented Oct 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@2113
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@2113
npm i https://pkg.pr.new/react-doctor@2113

commit: 65efacb

@aidenybai
aidenybai marked this pull request as ready for review October 18, 2026 04:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant