Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 09:42
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect status-aware local return nodes in a Set so the empty/nonempty check and repeated membership checks use the same AST node identities. The eager filter, predicates, validator control flow, and original rule tests remain unchanged.
The first macOS CI run exposed the existing cleanup-performance wall-clock ratio failure (442,104,833ns versus a 387,883,740ns bound). The follow-up changes only that previously reviewed performance fixture to count AST traversal work, preserving the 500/2,500 diagnostic-count assertions and scaling bound. Detector production is unchanged by this test repair. The original patch changeset remains; the test-only follow-up needs no additional changeset.
Validation: 120 existing status-rule tests plus two cleanup scaling tests; fresh full repository test graph (12 tasks), typecheck (10 tasks), lint, formatting, registry generation, serial build and JSON smoke passed. Six exact existing validator fixtures were compared through native oxlint against actual main base84ad and the reviewed Set refactor: all expected counts [0,0,1,0,1,1] and full diagnostic objects match. The committed production file is byte-identical to the independently reviewed source; tested and committed trees match. No new provider admission or shared semantic helper dependency was introduced. Full sandbox parity was not run for this behavior-equivalent refactor.
CI and review readiness are checked on the current pushed head, including a fresh natural React Doctor run after marking ready. No merge is performed.