Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 02:04
aidenybai
marked this pull request as draft
October 17, 2026 02:24
aidenybai
marked this pull request as ready for review
October 17, 2026 04:01
aidenybai
marked this pull request as draft
October 17, 2026 04:12
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
aidenybai
marked this pull request as ready for review
October 17, 2026 06:34
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A disabled button controlled by a readonly native state channel can protect its async handler from reentry.
What changed
Recognize the bounded disabling-state guard while retaining warnings for uncertain providers, escapes, and unsupported updates.
Resolve runtime references and writes to the nearest genuine value when erased TypeScript declarations share its name. Keep erased-only fallback and declaration identity intact. Reuse the shared erased-binding, namespace, and runtime-value helpers for conservative provider admission. Shared semantic controls cover imports, parameters, writes, local values, namespaces, and computed keys. Independent regressions and synthetic fuzz controls exercise the rule boundary. The patch changesets cover diagnostic and resolver behavior.
Known limits
Existing guard heuristics are unchanged. In particular, the named unlinked-disabling-flag-inherited-precision-limit regression remains quiet; this PR does not establish that every pre-existing guard heuristic links its flag to the button.
Test plan
3b813bf651818dd51998e1946bae08051c1ef095: 258 focused assertions passed.Fresh full-corpus parity was unavailable: required sandbox credentials (Daytona/Vercel as applicable), sibling RDE checkout, and repository cache are absent. Older sampled results are not parity for the revised head. No PR was merged.