Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 02:00
aidenybai
marked this pull request as draft
October 17, 2026 02:20
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
aidenybai
marked this pull request as ready for review
October 17, 2026 06:12
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow an effect that only replaces the route from props explicitly returned by the same Next Pages module’s data function. The exception requires detected Next.js, an eligible Pages file, the default page owner, readonly prop/router bindings, and a single guarded
router.replacecall.Keep warnings for extra work, unsupported page hosts, mutable or escaped providers, and ambiguous data transport. Readonly React default/namespace bindings may use static, direct
createElementcalls; other namespace uses retain the existing checks.Validation:
The tracked pre-commit checks passed when run manually because this isolated checkout lacks generated hook launchers. The captured Doctor child scanned 9 files and exited 0; its output does not attest execution of the selected rule and adds no React-rule coverage evidence.
Provider identity review follow-up
Provider admission preserves uncertainty for runtime references masked by erased TypeScript declarations. Genuine same-name values in lexical scope keep their existing behavior, including when an interface is declared later or inside a nested scope. The shared classifier covers type-only import-equals and uninstantiated namespaces; value-import and runtime namespace forms retain each detector's existing syntax boundary. Added independent synthetic regressions and fuzz seeds.
Runtime references and writes now attach to the nearest real value when an erased TypeScript declaration shares its name. Declaration identity stays unchanged, and erased-only lookup retains its existing behavior. Independent provider-exposure regressions cover nested interfaces and type aliases; the reviewed semantic source/test pair and six erasure helpers retain their canonical bytes.
Validation: 307 focused tests passed, including 82 shared helper controls. Strict 500-iteration target-rule fuzz, full repository test and typecheck graphs, lint, format check, registry check, serial build, and built CLI JSON-report smoke passed. Fresh full Daytona parity is unavailable because
DAYTONA_API_KEYis absent; the prior candidate evidence above remains unchanged.The repository graphs ran serially with the local Turbo cache read-only. The scoped stability fixtures retain deterministic pairing, cleanup, and boolean-toggle work counts, fake performance/timers for snapshot deadlines, and the existing seven-scan CLI comparison with a 60-second timeout.