Skip to content

feat(wellknown): add support for Maps in Set-Wellknown script #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
catalina-gav wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(wellknown): add support for Maps in Set-Wellknown script #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions internal/testhelp/fixtures/maps/map.json.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/fabric/item/map/definition/1.0.0/schema.json",
"basemap": {
"options": "{\"renderWorldCopies\":true}",
"controls": {
"zoom": true,
"pitch": true,
"compass": true,
"scale": true,
"traffic": true
},
"backgroundColor": null,
"theme": null
},
"dataSources": {
"lakehouses": [{{ .LAKEHOUSES | default "" }}],
"kqlDataBases": [
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property name 'kqlDataBases' uses inconsistent casing. Based on JavaScript/JSON naming conventions, it should be 'kqlDatabases' (lowercase 'b' in 'bases') to maintain camelCase consistency.

Suggested change
"kqlDataBases": [
"kqlDatabases": [

Copilot uses AI. Check for mistakes.
]
},
"layerSources": [
],
"layerSettings": [
]
}
6 changes: 5 additions & 1 deletion tools/scripts/Set-WellKnown.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,9 @@ function Set-FabricItem {
'Lakehouse' {
$itemEndpoint = 'lakehouses'
}
'Map' {
$itemEndpoint = 'maps'
}
'MirroredDatabase' {
$itemEndpoint = 'mirroredDatabases'
}
Expand Down Expand Up @@ -1119,6 +1122,7 @@ $itemNaming = @{
'KQLDatabase' = 'kqldb'
'KQLQueryset' = 'kqlqs'
'Lakehouse' = 'lh'
'Map' = 'map'
'MirroredDatabase' = 'mdb'
'MirroredWarehouse' = 'mwh'
'MLExperiment' = 'mle'
Expand Down Expand Up @@ -1238,7 +1242,7 @@ $wellKnown['WorkspaceDS'] = @{
Set-FabricWorkspaceRoleAssignment -WorkspaceId $workspace.id -SG $SPNS_SG

# Define an array of item types to create
$itemTypes = @('ApacheAirflowJob', 'CopyJob', 'Dataflow', 'DataPipeline', 'DigitalTwinBuilder', 'Environment', 'Eventhouse', 'GraphQLApi', 'KQLDashboard', 'KQLQueryset', 'Lakehouse', 'MLExperiment', 'MLModel', 'Notebook', 'Reflex', 'SparkJobDefinition', 'SQLDatabase', 'VariableLibrary', 'Warehouse')
$itemTypes = @('ApacheAirflowJob', 'CopyJob', 'Dataflow', 'DataPipeline', 'DigitalTwinBuilder', 'Environment', 'Eventhouse', 'GraphQLApi', 'KQLDashboard', 'KQLQueryset', 'Lakehouse', 'Map', 'MLExperiment', 'MLModel', 'Notebook', 'Reflex', 'SparkJobDefinition', 'SQLDatabase', 'VariableLibrary', 'Warehouse')

# Loop through each item type and create if not exists
foreach ($itemType in $itemTypes) {
Expand Down
Loading