feat(wellknown): add support for Maps in Set-Wellknown script #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Maps as a new item type in the Fabric well-known script, enabling the creation and management of Map items within the system.
Key Changes:
- Added 'Map' item type support with endpoint configuration and naming convention
- Created a fixture template for Map items with basemap and data source configurations
- Updated the list of supported item types to include Maps
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/scripts/Set-WellKnown.ps1 | Added Map item type configuration, naming convention, and included it in the array of supported item types |
| internal/testhelp/fixtures/maps/map.json.tmpl | Created a new JSON template for Map items with basemap settings and data source configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "dataSources": { | ||
| "lakehouses": [{{ .LAKEHOUSES | default "" }}], | ||
| "kqlDataBases": [ |
There was a problem hiding this comment.
The property name 'kqlDataBases' uses inconsistent casing. Based on JavaScript/JSON naming conventions, it should be 'kqlDatabases' (lowercase 'b' in 'bases') to maintain camelCase consistency.
Suggested change
| "kqlDataBases": [ | |
| "kqlDatabases": [ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
❓ What are you trying to address
Add support for Maps in Set-Wellknown script