Skip to content

fix(test): skip two symlink tests where the OS refuses symlinks #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yifan Yang (Yif-Yang) merged 1 commit into from
Sep 30, 2026
Merged

fix(test): skip two symlink tests where the OS refuses symlinks #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/test_superpowers_scenarios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,10 @@ def test_pytest_after_edit_fails_closed_on_broken_source_symlink(self):
ws = Path(tmpdir)
log = ws / "pytest.log"
log.write_text("run\n")
(ws / "broken.py").symlink_to(ws / "missing.py")
try:
(ws / "broken.py").symlink_to(ws / "missing.py")
except OSError:
pytest.skip("symlinks unavailable")
assert _pytest_after_edit(log, ws) is False

@pytest.mark.skipif(os.name != "posix", reason="test executes POSIX pytest shims")
Expand Down Expand Up @@ -869,7 +872,10 @@ def test_symlinked_candidate_refused(self):
real = Path(tmpdir) / "real.md"
real.write_text("# x")
link = Path(tmpdir) / "link.md"
link.symlink_to(real)
try:
link.symlink_to(real)
except OSError:
pytest.skip("symlinks unavailable")
with pytest.raises(ValueError, match="must not be a symlink"):
SuperpowersEvaluator().evaluate(candidate_skill_path=str(link))

Expand Down
Loading