Repository navigation
fix(test): skip two symlink tests where the OS refuses symlinks - #296
Merged
Yifan Yang (Yif-Yang) merged 1 commit intoSep 30, 2026
Conversation
test_pytest_after_edit_fails_closed_on_broken_source_symlink and test_symlinked_candidate_refused created symlinks directly. On Windows without Developer Mode or admin rights that raises OSError (WinError 1314), so the suite ended with two failures for every Windows contributor. Skip them in that case, the same way the other symlink tests in the suite already do. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestHarnessEvidence.test_pytest_after_edit_fails_closed_on_broken_source_symlinkandTestCLIFailClosed.test_symlinked_candidate_refusedcreate symlinks directly. On Windows without Developer Mode or admin rights that raisesOSError: [WinError 1314] A required privilege is not held by the client, sopython -m pytest -qends with 2 failures for every Windows contributor. #267 and #270 both list these two as unrelated failures.The other symlink tests in the suite already skip in that case (
except OSError: self.skipTest("symlinks unavailable")intest_sleep_adopt_skill_subset.pyandtest_sleep_engine.py). These two now do the same, usingpytest.skipbecause they are plain pytest classes. Nothing changes where symlinks work.On Windows 11 with Python 3.11,
python -m pytest -qwent from 2 failed, 1433 passed to 1433 passed, 75 skipped, 0 failed.ruff checkpasses on the file.🤖 Generated with Claude Code