-
Notifications
You must be signed in to change notification settings - Fork 402
chore: add min drain time #2726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v1.5.x
Are you sure you want to change the base?
chore: add min drain time #2726
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ryan-mist The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @ryan-mist. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| func (t *Terminator) Taint(ctx context.Context, node *corev1.Node, taint corev1.Taint) error { | ||
| // TaintForDisruption idempotently adds the karpenter.sh/disruption:NoSchedule taint | ||
| // and the karpenter.sh/disrupted-taint-time annotation to a node with a NodeClaim | ||
| func (t *Terminator) TaintForDisruption(ctx context.Context, node *corev1.Node) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are changing your Taint() method to TaintForDisruption(), but the Taint() method is still being used elsewhere.
ref: pretty.go
Wouldn't it be better to keep the Taint() method and add TaintForDisruption() as a separate method?
moko-poi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement unit tests.
Fixes #N/A
Description
MIN_NODE_DRAIN_TIMEto allow configuration of minimum time we spend draining the Node during terminationHow was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.