Skip to content

Conversation

@ryan-mist
Copy link
Contributor

Fixes #N/A

Description

How was this change tested?

  • manual testing to ensure annotation is added to the Node and minDrainTime is respected
Annotations:        alpha.kubernetes.io/provided-node-ip: 192.168.123.182
...
                    karpenter.sh/disrupted-taint-time: 2025-12-19T13:28:10-08:00
...
CreationTimestamp:  Fri, 19 Dec 2025 10:57:55 -0800
Taints:             karpenter.sh/disrupted:NoSchedule

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ryan-mist ryan-mist requested a review from a team as a code owner December 19, 2025 23:09
Copy link
Contributor Author

@ryan-mist ryan-mist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor Author

@ryan-mist ryan-mist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions
Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-d4385cd9b9b9b632d739474c50d363d2a9ed4b6f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-d4385cd9b9b9b632d739474c50d363d2a9ed4b6f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 20385333593

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 66.869%

Files with Coverage Reduction New Missed Lines %
pkg/fake/utils.go 2 95.09%
Totals Coverage Status
Change from base Build 18762091044: -0.02%
Covered Lines: 6929
Relevant Lines: 10362

💛 - Coveralls

@ryan-mist ryan-mist changed the title chore: add min drain time [do not merge] chore: add min drain time Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants