Repository navigation
Refresh standing docs for test DBs, owners, and Feature Map CI - #160
Merged
Merged
Conversation
Hooks run format and lint checks (not auto-fix). Route tests that import the shared db must migrate the throwaway DATABASE_PATH first. Name the in-tree remove-accents browser shim. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
crypto.ts mints ids and tokens, filter.ts owns directory-feed filterIn and filterOut, rate-limiter.ts is the token bucket, and MEDIA_ANALYTICS_MAX_SQLITE_VARIABLE_NUMBER is a process.env read outside the startup schema. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
CI checks the map through npm test, not the control CLI map --check subcommand. The /health summary now names the MCP protocol field that the snapshot already returns. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Bring standing docs in line with how MediaRSS works now: throwaway test databases need an explicit migrate, primitive owners that were missing, git hook checks (not auto-fix), and the Feature Map’s CI path.
Door: two-way
Cleanup: none
Why
A docs-freshness pass after #155. No product changelog language was left. The remaining drift was accuracy: contributing still implied the shared
dbwas ready to query, primitives omittedcrypto.ts/filter.ts/rate-limiter.tsand the analytics SQLite batch env, AGENTS.md read as if hooks auto-fixed format and lint, and the Feature Map banner said CI runsmap --check.Testing
npm run validate— format, lint, typecheck, 45 files / 306 tests (including Feature Map check). 3 pre-existing lint warnings, 0 errors.test/global-setup.ts,app/db/test-database.ts, route tests thatawait migrateDatabase(db),app/helpers/crypto.ts,app/helpers/filter.ts,app/helpers/rate-limiter.ts,app/assets.ts,app/routes/admin/api/media-analytics.$path.ts,.githooks/pre-commit,tools/feature-map.ts, and.github/workflows/publish.yml.No runtime or UI behavior change. Could not verify in a browser because this is docs-only.
System recap
Risk: low Touches:
docs/contributing.md,AGENTS.mddocs/primitives.mdtools/feature-map.ts,tools/feature-notes.ts)(extends)
migrateDatabase(db)for shared-db route tests and theremove-accentsbrowser shim.MEDIA_ANALYTICS_MAX_SQLITE_VARIABLE_NUMBER.npm test. The/healthnote names the MCP protocol field.Note
Low Risk
Documentation and generated Feature Map text only; no application code or behavior changes.
Reviewed by Cursor Bugbot for commit 9c4bb94. Bugbot is set up for automated code reviews on this repo. Configure here.