Repository navigation
Refresh standing docs for health, owners, and contributor map - #161
Merged
Merged
Conversation
Keep the version pins and validate/check commands on the map pages; drop the duplicated CI, hooks, command list, and data-layer walkthrough. Document the /health snapshot and MEDIA_ANALYTICS_MAX_SQLITE_VARIABLE_NUMBER on the operator README. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Name the asset server, format helpers, and CSS token files. Describe throwaway test DBs as unmigrated WAL files. Record createMcpHandler legacy: reject, /mcp GET+OPTIONS, and the remaining control CLI flags. Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Bring standing docs in line with how MediaRSS works now: the
/healthsnapshot, MCP transport, missing primitive owners, and a thinner AGENTS/README map that points at contributing.Door: two-way
Cleanup: none
Why
A docs-freshness pass after #160. No product changelog language was left. Remaining drift was accuracy and duplication: AGENTS and README Development repeated the contributing gate;
/healthomitted OAuth;MEDIA_ANALYTICS_MAX_SQLITE_VARIABLE_NUMBERwas only in primitives; throwaway test DBs were called empty files; primitives omittedapp/assets.ts,format.ts, and the CSS token split; the Feature Map listed/mcpas POST-only.Testing
npm run validate— format, lint, typecheck, 45 files / 306 tests (including Feature Map check). 3 pre-existing lint warnings, 0 errors.npm run --silent control -- map --write.app/helpers/health.ts,app/routes/mcp/index.ts,app/mcp/cors.ts,app/db/index.ts,test/global-setup.ts,app/assets.ts,app/helpers/format.ts,app/assets/styles.css,app/routes/admin/api/media-analytics.$path.ts, andtools/control-mediarss.ts.No runtime or UI behavior change. Could not verify in a browser because this is docs-only.
System recap
Risk: low Touches:
AGENTS.md,README.md,docs/contributing.mddocs/primitives.md,docs/mcp-server-best-practices.mdtools/feature-notes.ts)(extends)
/healthnames MCP and OAuth; README listsMEDIA_ANALYTICS_MAX_SQLITE_VARIABLE_NUMBER./mcpmethods areGET, POST, OPTIONS; health note includes OAuth.Note
Low Risk
Markdown and generated Feature Map notes only; no application code paths change.
Reviewed by Cursor Bugbot for commit 6659385. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
GET,POST, andOPTIONS.