Repository navigation
fix(web): localize and align profile membership dates - #206
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile membership dates now use a complete localized phrase and align the calendar icon with the text bottom. Both profile surfaces preserve the semantic timestamp and the existing exact-time tooltip.
Validation:
mise exec -- pnpm --dir web test src/features/profile/ProfilePage.test.tsx src/features/profile/MemberProfilePage.test.tsx src/i18n/i18n.test.tspassed all 27 tests.mise exec -- pnpm --dir web build, focused ESLint, Prettier and diff checks passed.Timestamp assertions continue checking the containing time element after the translated label gains an inline wrapper. Full CI and release checks were omitted because the changes are limited to profile metadata markup, styling and translations.
Closes #203