Split date and time format in settings and fix formatting - #806
Merged
correct-horse-battery-bench merged 5 commits intoAug 13, 2026
Merged
Conversation
correct-horse-battery-bench
changed the title
correct-horse-battery-bench
marked this pull request as ready for review
August 11, 2026 09:50
novasam23
previously approved these changes
Aug 11, 2026
…-formatting-settings-in-ui-config-menu # Conflicts: # src/app/core/_components/tables/users-table/users-table.component.ts
novasam23
approved these changes
Aug 13, 2026
correct-horse-battery-bench
deleted the
2064-bug-weird-time-formatting-settings-in-ui-config-menu
branch
August 13, 2026 09:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date and time format were previously combined as one setting which should be configurable separately.
Also the call site where we display a time should specify which precision is used instead of the global ui settings as depending on where we format a time a different precision (minutes, seconds) is needed.
In addition, the formatting function which was custom written had errors and was replaced with a library date and time formatting function.
See issue description for more details.
Issue: hashtopolis/server#2064