Skip to content

Store trace timestamps as microtime floats instead of integers #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertvansteen merged 1 commit into from
Feb 20, 2026
Merged

Store trace timestamps as microtime floats instead of integers #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TracingResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public function resolve(Source $source): Result
$duration = (microtime(true) - $start) * 1000;

// Generic metadata — captured for every node automatically
$node->addMetadata('timestamp', (int) $start);
$node->addMetadata('timestamp', $start);
$node->addMetadata('duration_ms', round($duration, 3));
$node->addMetadata('outcome', $result->isOk() ? 'ok' : 'err');

Expand Down
8 changes: 4 additions & 4 deletions tests/TracingResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,16 +219,16 @@ public function test_duration_is_non_negative(): void
$this->assertGreaterThanOrEqual(0, $duration);
}

public function test_timestamp_is_a_unix_timestamp(): void
public function test_timestamp_is_a_microtime_float(): void
{
$before = (int) microtime(true);
$before = microtime(true);
$tracer = $this->createResolver();

$traced = $tracer->traced(new StaticSource(1));
$after = (int) microtime(true);
$after = microtime(true);

$timestamp = $traced->trace->getMetadata('timestamp');
$this->assertIsInt($timestamp);
$this->assertIsFloat($timestamp);
$this->assertGreaterThanOrEqual($before, $timestamp);
$this->assertLessThanOrEqual($after, $timestamp);
}
Expand Down