Store trace timestamps as microtime floats instead of integers - #10
Merged
Merged
Conversation
Removes the (int) cast on the microtime(true) value so timestamps retain microsecond precision. Updates the corresponding test to assert a float. https://claude.ai/code/session_01CNzHGDAxDHo3s1sMhrLALx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed the trace timestamp metadata to store the full microtime float value instead of casting it to an integer, providing microsecond precision instead of second precision.
Key Changes
TracingResolver::resolve()to store the raw$startmicrotime value instead of casting it to(int) $starttest_timestamp_is_a_unix_timestamp()to:test_timestamp_is_a_microtime_float()to reflect the new behavior$beforeand$aftercomparison valuesImplementation Details
This change improves timing precision in trace metadata by preserving microsecond-level accuracy from
microtime(true). The timestamp can now be used for more precise performance analysis and debugging without losing sub-second resolution.https://claude.ai/code/session_01CNzHGDAxDHo3s1sMhrLALx