fix #5026 issue and refactor ModelScene.ts#5101
Open
mohammadbaghaei wants to merge 1 commit intogoogle:masterfrom
Open
fix #5026 issue and refactor ModelScene.ts#5101mohammadbaghaei wants to merge 1 commit intogoogle:masterfrom
mohammadbaghaei wants to merge 1 commit intogoogle:masterfrom
Conversation
diegoteran
reviewed
Feb 3, 2026
| warp = parseFloat(warp); | ||
| } else { | ||
| warp = false; | ||
| console.warn('Invalid warp value, warp is set to false'); |
Collaborator
There was a problem hiding this comment.
There are a few console warning that were deleted, do you think it might be worth it to keep them for model-viewer users to get more info if something is not working as intended?
diegoteran
requested changes
Feb 3, 2026
Collaborator
diegoteran
left a comment
diegoteran
left a comment
There was a problem hiding this comment.
Thank you, looks good. would just appreciate the warnings to stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.