Skip to content

To fix issue #5009, add width attribute to .sidebar#5107

Merged
diegoteran merged 1 commit intogoogle:masterfrom
mohammadbaghaei:fix-#5009-issue
Feb 2, 2026
Merged

To fix issue #5009, add width attribute to .sidebar#5107
diegoteran merged 1 commit intogoogle:masterfrom
mohammadbaghaei:fix-#5009-issue

Conversation

@mohammadbaghaei
Copy link
Contributor

No description provided.

@cdeil cdeil mentioned this pull request Jan 30, 2026
@elalish
Copy link
Contributor

elalish commented Jan 30, 2026

@diegoteran @samaneh-kazemi Hello from NZ! How's the Google team a year on? I can't help but notice it's been 9 months since your last release, despite having ~25 merged PRs since then, not to mention at ~7 open PRs from external contributors that look pretty helpful and haven't even been reviewed. Anyone willing to spend half a day for the sake of the community?

Or has <model-viewer> already been completely orphaned? If so, you should probably at least offer it to Khronos or something.

@diegoteran
Copy link
Collaborator

Thank you, @mohammadbaghaei !

@diegoteran diegoteran self-requested a review February 2, 2026 23:32
@diegoteran diegoteran merged commit 01e0e42 into google:master Feb 2, 2026
3 checks passed
@mohammadbaghaei
Copy link
Contributor Author

mohammadbaghaei commented Feb 3, 2026

Finally, great to see this moving!

Thank you @elalish for your attention and constructive feedback. As you mentioned, the ModelViewer community has unfortunately been quite inactive over the past year. I believe this project has immense potential, and it’s a pity to see it stall. Regular PR reviews and consistent releases would definitely motivate more developers to contribute.

I’d also like to thank @diegoteran for the review. It would be great if you could take a look at the other pending PRs as well.

PRs:
#5101 #5102 #5103 #5104 #5105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants