Preserve sidebar footer disclosure state across route remounts - #3247
Open
bb-slop-cop[bot] wants to merge 1 commit into
Open
Preserve sidebar footer disclosure state across route remounts#3247bb-slop-cop[bot] wants to merge 1 commit into
bb-slop-cop[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
The managed sidebar-footer host kept its active disclosure key only in React state owned by
AppSidebar. On wide settings and tools routes, the layout replaces that component, so returning mounted a fresh hook initialized with no active disclosure. The verified reproduction and root-cause report is https://get-bb.github.io/reports/issues/3245.html.What changed
The existing sidebar-footer host now retains the active registration key across host remounts and updates it on open, close, toggle, and dismiss actions. A focused regression test covers persistence across a remount and confirms that an explicit close still clears the retained state. There are no wire, protocol, CLI, dependency, schema, generated-file, or stored-data changes.
How you verified
origin/mainbecause the remounted trigger hadaria-expanded="false", then passed after the fix.pnpm exec turbo run test --filter=@bb/app -- src/components/plugin/PluginSidebarFooterItems.test.tsx src/components/plugin/PluginSidebarFooterItems.persistence.test.tsx src/components/layout/AppLayoutSidebar.test.tsx— 10 tests passed.pnpm exec turbo run typecheck --filter=@bb/app— passed.pnpm exec oxfmt --check ...andgit diff --check— passed.Fixes #3245