Repository navigation
ci: pin Node to 24.15.0 - #196
Merged
Merged
Conversation
Node 24.16.0 (pulled in by check-latest) hangs Playwright's browser download at 100% — the stream never finalizes, deterministically, for every browser. The last green run (Apr 30) used 24.15.0 with the same workflow. Pin it and bump deliberately with a verified run instead of floating to whatever the runner cache serves.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
justin-schroeder
left a comment
justin-schroeder
left a comment
Member
Author
There was a problem hiding this comment.
Review notes: evidence chain is in the PR body — the Node patch delta is the only changed variable between green and hanging runs, verified from the Verify-runtime step output of both. Pin is exact (24.15.0) rather than a range so the fix can't silently float away. The npm update step is unrelated to the stall (pnpm drives everything) and left as is.
This was referenced Jun 11, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final piece of the CI fix (with #193 sharding and #195 install bounding).
Diagnosis
With #195's bounded retries, the stall became observable: every browser download (chromium/firefox/webkit), every attempt, reaches 100% and never finalizes. Comparing runtimes:
check-latest: trueSame workflow, same Playwright, same CDN — the only delta is the Node patch version. 24.16.0 has a stream-finalization regression that Playwright's downloader trips over.
Fix
Pin
node-version: 24.15.0and dropcheck-latest— future bumps should be deliberate, verified by a green run. The #195 retry bound stays as a safety net (a genuine CDN stall now costs minutes, not the job).The run triggered by this merge is the end-to-end validation.