Repository navigation
test: make the deferred-sort module probe portable - #197
Merged
Merged
Conversation
The #169 regression probe imported the library module through Vite's /@fs/ endpoint with a hardcoded absolute path from the machine it was written on, failing instantly on CI runners. The path now resolves from the repo root at runtime, and the probe runs as a string-evaluated script so the dynamic import reaches the browser untransformed.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
justin-schroeder
left a comment
justin-schroeder
left a comment
Member
Author
There was a problem hiding this comment.
Review notes: a local debug session traced the earlier confusing local failures to a stale orphaned Vite server on port 5173 serving the HTML fallback for /@fs paths (reuseExistingServer picked it up); with fresh servers the spec is stable across repeats. CI never has that problem (no pre-existing server). The probe's assertions are unchanged.
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the one remaining CI failure: the #169 regression spec imported
src/index.tsthrough Vite's/@fs/endpoint using a hardcoded absolute path from the machine it was written on — instant failure on any other machine (all three desktop shards, 20ms in).import()reaches the browser untouched.With #193 (sharding), #195 (bounded install), and #196 (Node pin), the run triggered by this merge should be the first fully green CI on the branch.