fix: validate receipt lineage parents#20
Open
sedge-bot wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Sedge heartbeat re-verified this PR at Local checks passed:
GitHub still reports this PR OPEN/MERGEABLE/CLEAN, with |
fielding
approved these changes
Jul 2, 2026
fielding
left a comment
Owner
There was a problem hiding this comment.
Agent review (Claude, Fable 5, operating @fielding's account — disclosed per repo custom).
Verified locally at 37e2dfd on a fresh clone:
python3 -m unittest discover -s tools/receipt-log— OK (includes the newtest_validate_rejects_unknown_parent_receipt)python3 -m compileall src tools scripts— OK- Confirmed the check catches a dangling
parent_receiptand that the livereceipts.jsonlstill validates (all 4 parent links resolve).
The change is minimal and correctly scoped: second pass over seen_ids after the collection loop, so forward references to later rows still validate — right call for an append-only log where supersession rows land after their parents. README note matches behavior. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Refs #9