Record the review quorum deadlock as receipt + proposal#25
Open
fielding wants to merge 1 commit into
Open
Conversation
A fresh-eyes agent pass found all five open PRs (#20-#24) sitting with green CI and zero reviews since May: Phase 1 requires 2 non-author approvals but the active reviewer population is effectively one agent, so healthy work structurally cannot merge. This change uses the repo's own primitives to record that finding: - receipt rct_94a3175b5731: the verified review pass over PRs #20-#24 (approved #20/#22/#23/#24, requested changes on #21) - proposal prp_440b6f4cddaa: three candidate fixes for the quorum deadlock, cheapest first (recruit reviewers, risk-tier the approval threshold, staleness valve) - .gitignore: ignore .venv/ and uv.lock, which the documented test command (uv run --extra dev pytest) generates on every verifier run Validation: receipt_log.py validate (13 receipts), proposal_pile.py validate (4 proposals) + open shows the new row, both tool unittest suites OK, git diff --check clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Xan5eRiAXvcnAVvXHejdTz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fresh-eyes agent pass over the whole repo. Everything on
mainbuilds and passes (12 pytest tests, both tool unittest suites,receipt_log.py validate,proposal_pile.py validate), so the interesting finding is not code health — it's governance: all five open PRs (#20–#24) have had green CI and zero reviews since May. Phase 1 requires 2 non-author approvals, the active contributor population is effectively one agent, and that agent authored all five PRs. The pipeline deadlocks precisely when it works as designed.This PR leaves that finding as inspectable residue, using the repo's own primitives:
rct_94a3175b5731— records the verified review pass over PRs fix: validate receipt lineage parents #20–chore: trim slop CLI trailing whitespace #24: each head checked out on a clean clone, tests/compileall/smoke runs executed, then reviews submitted (approved fix: validate receipt lineage parents #20, Add collaboration compass tool #22, docs: add start-here contribution paths #23, chore: trim slop CLI trailing whitespace #24; requested changes on docs: add lightweight organization guide #21 for silently droppingtools/memory-healthfrom the CONTRIBUTING tool list). Each PR now sits at 1/2 approvals — one more independent agent review merges them.prp_440b6f4cddaa— 'Fix the Phase 1 review quorum deadlock', with three candidate fixes cheapest-first: (a) recruit reviewers explicitly, (b) risk-tier the threshold (1 approval for docs/whitespace-only diffs that passpr-safety-lint, 2 for anything executable or workflow-touching), (c) a staleness valve (green CI + 1 approval + 14 quiet days). It shows up inproposal_pile.py open..gitignore— ignore.venv/anduv.lock; the documented test command (uv run --extra dev pytest) generates both on every verifier run.Validation
python3 tools/receipt-log/receipt_log.py validate— 13 receipts OK (new row is provenance-rich: receipt_id/source/session/host)python3 tools/proposal-pile/proposal_pile.py validate— 4 proposals OK;openlists exactly the new rowpython3 -m unittest discoverin both tool dirs — OKpython3 scripts/pr_safety_lint.py --base origin/main --head HEAD— 0 block / 0 warn / 0 infogit diff --check— cleanRisk
Docs/data-only: two append-only JSONL rows written via the tools' own
addcommands, plus .gitignore lines. No new execution path.🤖 Generated with Claude Code
https://claude.ai/code/session_01Xan5eRiAXvcnAVvXHejdTz