Skip to content

This fixes an exception thrown when using GoRouter #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnlklink merged 2 commits into from
Sep 25, 2026
Merged

This fixes an exception thrown when using GoRouter #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2550e4d
Removed the `SelectionArea` wrapping `child` - this doesn't work with…
cnlklink Sep 25, 2026
81f4a5b
Bump `version` to `1.4.0`
cnlklink Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/src/app_scaffold.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,18 @@ final class _DrawerHeaderState extends State<_DrawerHeader> {
null,
),

(null, true) =>
_buildAuthHeader(Icons.no_accounts_sharp, "Unauthorized", (
(null, true) => _buildAuthHeader(
Icons.no_accounts_sharp,
"Unauthorized",
(
"Login",
() => closeDrawerThen(() {
infoBox(context, "Log in", "Contacting KeyCloak ...");
AuthService.requestLogin(context);
}),
), _buildMissingRolesWarning(context, widget.neededRoles)),
),
_buildMissingRolesWarning(context, widget.neededRoles),
),

(UserInfo user, true) => _buildAuthHeader(
Icons.account_circle,
Expand Down Expand Up @@ -496,8 +500,7 @@ final class _RouterApp extends StatelessWidget {
theme: theme.light,
darkTheme: theme.dark,
routerConfig: router,
builder: (context, child) =>
SelectionArea(child: child ?? const SizedBox()),
builder: (context, child) => child ?? const SizedBox(),
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flutter_controls_core
description: A Flutter package to write Fermilab applications.
version: 1.3.0
version: 1.4.0
publish_to: none

environment:
Expand Down
Loading