Repository navigation
This fixes an exception thrown when using GoRouter - #144
Merged
Merged
Conversation
Code Coverage Report - 119 of 353 lines covered ( ⛔ 33.71%)
|
Contributor
|
That's unfortunate but it makes sense. Just a minor request, could you up the version in |
Code Coverage Report - 119 of 353 lines covered ( ⛔ 33.71%)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removes the
SelectionAreathat is inserted into the widget tree by_RouterApp. Unfortunately this won't work correctly withGoRouterbecause theSelectionAreaends up as the parent ofOverlaywith how the router works. Instead the developer needs to insertSelectionAreafor eachRoutetheir app builds.