Conversation
jaimeiniesta
added
bug
Introduces a helper to strip p tags where needed
jaimeiniesta
force-pushed
the
fix-html-p-inside-h1
branch
from
0d3f1ca to
26e2630
Compare
doomspork
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in the latest Rocket Validator report, post titles had
<p>tags inside<h1>tags, which is not allowed.As the post titles come from NimblePublisher they contain
<p>tags, so I added a quick helper to strip those p tags where needed.Maybe we should review if we instead want the post titles to be simple strings, without HTML tags.
Update: we need to keep tags in titles as long as we use code blocks in the titles, as in https://github.com/elixirschool/elixirschool/blob/main/posts/2019-02-06-til-send-after.md?plain=1#L6