fixes HTML error, p is not allowed as a child of span#242
Merged
Conversation
This affected post previews. Changing span for div fixes the issue.
jaimeiniesta
added
rocket validator
doomspork
approved these changes
Aug 20, 2025
Member
doomspork
left a comment
doomspork
left a comment
There was a problem hiding this comment.
Good catch, thank you @jaimeiniesta! 🫶
Contributor
Author
|
Cool, we've smashed 646 HTML errors from the site! The latest report shows this issue is now gone, there's only one HTML issue left that should be fixed by #243 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in the latest Rocket Validator report, post previews had an HTML issue as some
<p>tags were inside<span>elements, which is not allowed.Changing the
<span>by<div>fixes the issue by now, later we should think of a more semantic approach for this, probably.