feat(pty): add platform-neutral session contract - #34
Merged
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #33
status:approvedlabel.Pull request type
Select exactly one option and apply the matching
type:*label.type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
Changes
crates/splice-pty/src/lib.rscrates/splice-pty/tests/session_contract.rsTest plan
cargo fmt --all --check;cargo test -p splice-pty(16/16 passed);cargo clippy -p splice-pty --all-targets -- -D warnings(passed).Chained pull request context
masterat1c02999alib.rs, then the contract scenarios insession_contract.rsChain Context
masterat PR1 merge1c02999amasterChain Overview
Scope
Autonomy
Rollback
Revert commit
cf7306bto remove only the shared session contract, its Windows adaptation, andsession_contract.rs; PR1 and unrelated PTY flow-control behavior remain intact.Contributor checklist
Closes,Fixes, orResolves.type:*label.Co-Authored-Bytrailers.