feat(pty): harden Unix PTY lifecycle - #38
Merged
Merged
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #37
status:approvedlabel.Pull request type
Select exactly one option and apply the matching
type:*label.type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
Changes
crates/splice-pty/src/lib.rscrates/splice-pty/tests/unix_pty.rsTest plan
cargo fmt --all -- --check,cargo test -p splice-pty(31/31), andcargo clippy -p splice-pty --all-targets -- -D warningspassed.SDD verdict: PASS WITH WARNINGS. The scoped native package checks are green. Workspace-wide tests remain blocked by the pre-existing missing
apps/desktop/src-tauri/icons/icon.png.R3-002remains informational: writer-lock fallback signals the shell/session process group, not a separately discovered foreground process group.Chained pull request context
Stacked-to-
masterdelivery; each slice is independently reviewable and revertible. Prior PRs are merged.Review budget: 165 additions + 20 deletions = 185 changed lines across 2 files, below the 400-line limit.
Rollback boundary: revert commit
f18e59dto remove only the Unix lifecycle hardening and its focused regressions; prior PTY backend behavior remains intact.Contributor checklist
Closes,Fixes, orResolves.type:*label.Co-Authored-Bytrailers.