Skip to content

chore!: forward-merge v4.2-dev into v4.3-dev - #5148

Closed
infraclaw-dash wants to merge 118 commits into
dashpay:v4.3-devfrom
infraclaw-dash:merge/v4.2-into-v4.3-20260928
Closed

infraclaw-dash wants to merge 118 commits into
dashpay:v4.3-devfrom
infraclaw-dash:merge/v4.2-into-v4.3-20260928

Conversation

@infraclaw-dash

@infraclaw-dash infraclaw-dash commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Issue being fixed or feature implemented

Forward-merge v4.2-dev into v4.3-dev so the newer development branch receives the already-merged fixes, including the runner-image/workflow changes required by the current self-hosted CI environment.

Concrete failure: Kotlin CI for #5146 still runs android-actions/setup-android@v3. It tries to install command-line tools into the root-owned, prebaked /opt/android-sdk and fails with cannot create cmdline-tools — Permission denied, before compilation.

The compatible ordinary-CI workflow is already on v4.2-dev via #4702: select/verify the pinned runner image and use its prebaked SDK instead of mutating it. #5141 fixes a separate release-workflow NDK-path issue; that release-only change did not repair this branch's ordinary Kotlin CI.

What was done?

  • Opened the requested full branch forward merge, head infraclaw-dash:merge/v4.2-into-v4.3-20260928, base dashpay:v4.3-dev.
  • The head is an exact snapshot of upstream v4.2-dev at the source SHA below, with no additional commits. A dedicated fork branch is used because the author does not have upstream collaborator permission; the protected source/target branches remain untouched.
  • This brings the complete upstream branch history, not only CI changes. Application, SDK, protocol and dependency changes already merged into v4.2-dev are also in scope for review.
  • No new source changes or conflict resolutions were authored for this PR. No target branch was reset, force-pushed or merged.
  • Preserve v4.3-dev-specific changes when resolving conflicts. Prefer an ancestry-preserving merge for branch synchronization rather than squash/rebase, subject to repository policy. Do not resolve target-specific conflicts by changing the shared v4.2-dev branch.

Preflight snapshot:

  • Source: 1464314a7a0a543fccda21bed6bcd4521f0eda69
  • Target: 67340ad82406cb36147234bc46f6c572c78ecef9
  • GitHub comparison: 118 source-only commits, 33 target-only commits; histories have diverged.

How Has This Been Tested?

  • Read the exact failed job log and workflow revision.
  • Read-only inspection of the actual runner confirmed UID 1001, root-owned SDK directories and non-writable command-line-tools installation paths.
  • Compared the ordinary Kotlin workflow on both branches and verified the repair is on v4.2-dev.
  • Verified branch direction and checked that no duplicate open forward-merge PR exists.
  • Fork-origin self-hosted jobs may be skipped by repository policy; skipped is not a successful build. A maintainer-controlled trusted validation path is needed before claiming the merged workflow works.
  • The combined merge result has not been built or tested. Conflict review and fresh CI against the resulting merge are required. This PR is not a claim that every CI or application failure is resolved; rerunning an old captured workflow is not proof of the new one.

Breaking Changes

This full forward merge includes existing upstream breaking changes; it is not a CI-only patch. Review protocol/version-specific behavior against the intended v4.3-dev release line. The PR title is marked accordingly.

Checklist

  • Verified source/target direction and investigated the reported CI failure
  • Reviewed the complete combined application/protocol diff
  • Resolved any integration conflicts while preserving target-specific changes
  • Fresh CI passes on the proposed merge result
  • Maintainer approval to merge

Opened by infraclaw at latte's request. Leave unmerged for review.

PR Hygiene · 1464314

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — not asked of a bot author
  • Within your 5 open PRs
  • Build failed
  • Approvals
    • files with no dedicated owner (.claude/skills/pr-description/SKILL.md, .editorconfig, .github/NPM_RUNNER.md and 220 more) — QuantumExplorer or shumkov
    • dashmate (packages/dashmate/package.json) — ktechmidas or shumkov
    • system-contracts (packages/dashpay-contract/README.md, packages/dashpay-contract/package.json, packages/document-history-contract/package.json and 6 more) — QuantumExplorer or shumkov
    • js-wasm-sdk (packages/js-dash-sdk/package.json, packages/js-evo-sdk/README.md, packages/js-evo-sdk/package.json and 17 more) — shumkov
    • kotlin-sdk (packages/kotlin-sdk/CLAUDE.md, packages/kotlin-sdk/KotlinExampleApp/TEST_PLAN.md, packages/kotlin-sdk/KotlinExampleApp/app/src/main/java/org/dashfoundation/example/ui/contracts/CreateDocumentScreen.kt and 18 more) — HashEngineering
    • dpp (packages/rs-dpp/schema/meta_schemas/document/v3/document-meta.json, packages/rs-dpp/src/address_funds/fee_strategy/mod.rs, packages/rs-dpp/src/address_funds/platform_address.rs and 129 more) — QuantumExplorer or shumkov
    • rs-drive-abci (packages/rs-drive-abci/src/abci/app/check_tx.rs, packages/rs-drive-abci/src/abci/app/consensus.rs, packages/rs-drive-abci/src/abci/app/full.rs and 97 more) — QuantumExplorer or shumkov
    • rs-drive (packages/rs-drive/grovedb-structure.json, packages/rs-drive/src/config.rs, packages/rs-drive/src/drive/contract/get_fetch/get_contract_with_fetch_info/mod.rs and 143 more) — QuantumExplorer or shumkov
    • rs-platform-wallet-ffi (packages/rs-platform-wallet-ffi/src/document.rs, packages/rs-platform-wallet-ffi/src/dpns.rs, packages/rs-platform-wallet-ffi/src/identity_keys_from_mnemonic.rs) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rs-platform-wallet (packages/rs-platform-wallet/PERSISTENCE_REDESIGN.md, packages/rs-platform-wallet/PLAN.md, packages/rs-platform-wallet/docs/DASHPAY_MIGRATION_PLAN.md and 25 more) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rust-sdk-ffi (packages/rs-sdk-ffi/src/data_contract/mod.rs, packages/rs-sdk-ffi/src/data_contract/property_constraints.rs, packages/rs-sdk-ffi/src/data_contract/put.rs and 30 more) — lklimek or shumkov
    • rust-sdk (packages/rs-sdk/src/platform/documents/contest_fund.rs, packages/rs-sdk/src/platform/documents/mod.rs, packages/rs-sdk/src/platform/documents/transitions/create.rs and 5 more) — lklimek or shumkov
    • swift-sdk (packages/swift-sdk/CLAUDE.md, packages/swift-sdk/Sources/SwiftDashSDK/Core/Utils/DocumentPropertyConstraints.swift, packages/swift-sdk/Sources/SwiftDashSDK/Core/Wallet/WalletStorage.swift and 62 more) — llbartekll or romchornyi

When every box is checked the PR Hygiene check passes and this can merge.

QuantumExplorer and others added 30 commits September 27, 2026 09:32
…eir own round (dashpay#5010)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rm (PV14) (dashpay#5007)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…in another round (dashpay#5028)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…range read (dashpay#5030)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (dashpay#5031)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…shpay#4964)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…heck (dashpay#5032)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ne (PV14) (dashpay#5029)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ay#4562)

Co-authored-by: Quantum Explorer <quantum@dash.org>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
… contest holds past 250 (PV14) (dashpay#5034)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…V14) (dashpay#5036)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s (PV14) (dashpay#5037)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…V14) (dashpay#5038)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…e join price (PV14) (dashpay#5039)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ments live in (PV14) (dashpay#5033)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…es (PV14) (dashpay#5042)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…shpay#5044)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… rules (PV14) (dashpay#5045)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s (PV14) (dashpay#5046)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…(PV14) (dashpay#5047)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…V14) (dashpay#5048)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…shpay#5055)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…act v2 (dashpay#5056)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pay#5050)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nd iOS example app (dashpay#5064)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…and Android example app (dashpay#5066)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
ktechmidas and others added 22 commits September 28, 2026 17:17
…roperty (PV14) (dashpay#5127)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…use (dashpay#5137)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…urns the vote (dashpay#5138)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…and (dashpay#5136)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…y#5140)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…plete (dashpay#5103)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#5105)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…variants (dashpay#5125)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…(PV14) (dashpay#5104)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: da78f791-d41b-43b4-be51-2dfd49aa458f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added this to the v4.3.0 milestone Sep 28, 2026
@thepastaclaw

thepastaclaw commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 2nd in line, estimated start in ~30 min (commit 1464314)
Estimated review time once started: ~0.9 h (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 28, 2026
@PastaPastaPasta PastaPastaPasta mentioned this pull request Sep 28, 2026
2 of 24 tasks
@PastaPastaPasta

Copy link
Copy Markdown
Member

Superseded by #5151. That PR is an actual merge commit of v4.2-dev into v4.3-dev with the dpns.rs import conflict resolved and a fix for a PV15 build break: v15.rs referenced DRIVE_ABCI_QUERY_VERSIONS_V3, which #5057 removed on v4.2-dev. Its branch is on dashpay, so self-hosted CI can run.


🤖 Posted autonomously by Codex on behalf of pasta.

This branch was successfully deployed

1 active deployment
github-pages — 1464314a Deployed Sep 28, 2026 by QuantumExplorer via Deploy to GitHub Pages #965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants