Skip to content

chore!: forward-merge v4.2-dev into v4.3-dev - #5189

Closed
ktechmidas wants to merge 148 commits into
v4.3-devfrom
merge/v4.2-into-v4.3-internal-20260929
Closed

ktechmidas wants to merge 148 commits into
v4.3-devfrom
merge/v4.2-into-v4.3-internal-20260929

Conversation

@ktechmidas

@ktechmidas ktechmidas commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Issue being fixed or feature implemented

Forward-merge v4.2-dev into v4.3-dev as requested by latte. Prepared by infraclaw using latte's explicitly requested PAT/internal-branch route, not a fork PR, so existing same-repository CI admission applies.

What was done?

  • Created only the dedicated internal snapshot branch merge/v4.2-into-v4.3-internal-20260929 at exact source 3190d4e50c45edfe374d735981f9ddfd75a46f40.
  • Target snapshot: 67340ad82406cb36147234bc46f6c572c78ecef9. Server-side comparison reports 147 source-only and 33 target-only commits.
  • This is full application/dependency/CI history, not a CI-only cherry-pick. No new application edits or synthetic source commit were made.
  • Shared development branches and contributors' PR branches were not pushed, rebased, force-pushed or retargeted. No protections or fork trust were changed.

First leg of the requested v4.2-dev -> v4.3-dev -> v5.0-dev sequence. The second PR will be linked separately and must be refreshed from the resulting v4.3 merge before it is landed.

Replaces the closed fork-based #5148 with a fresh internal snapshot so ordinary same-repository CI is eligible. The existing CI-only repair #5166 is not merged or closed by this PR; compare its remaining contribution after this integration.

How Has This Been Tested?

  • Verified the source/target snapshots and the internal ref against GitHub.
  • Ref content is byte-identical to the selected source commit; no full test pass is claimed.
  • Target mergeability, conflicts and fresh PR-attributable CI must be checked on GitHub. Being internal permits trusted jobs but is not itself proof they ran or passed.
  • Preserve target-specific application changes when resolving conflicts. No blanket ours/theirs resolution or test suppression.

Breaking Changes

Potential breaking changes are inherited from the full source history and require normal release/application review. Creating this PR does not authorize automatic merging of application history. Runner image deployment and capacity remain separate operational gates.

Checklist:

  • I have performed a self-review of the branch/publication scope
  • Application/dependency changes and any merge conflicts reviewed
  • Fresh target-specific CI completed
  • Required independent reviews complete

PR Hygiene · 51b781d

  • Bots — coderabbitai not yet · thepastaclaw not yet — /skip-bots proceeds without the ones not yet reported
  • Self-review — post /self-reviewed once the bots are done
  • Within your 5 open PRs
  • Build running
  • Approvals
    • files with no dedicated owner (.claude/skills/pr-description/SKILL.md, .editorconfig, .github/NPM_RUNNER.md and 253 more) — QuantumExplorer or shumkov
    • dashmate — you own it
    • system-contracts (packages/dashpay-contract/README.md, packages/dashpay-contract/package.json, packages/document-history-contract/package.json and 6 more) — QuantumExplorer or shumkov
    • js-wasm-sdk (packages/js-dash-sdk/package.json, packages/js-evo-sdk/README.md, packages/js-evo-sdk/package.json and 32 more) — shumkov
    • kotlin-sdk (packages/kotlin-sdk/CLAUDE.md, packages/kotlin-sdk/KotlinExampleApp/TEST_PLAN.md, packages/kotlin-sdk/KotlinExampleApp/app/src/main/java/org/dashfoundation/example/ui/contracts/CreateDocumentScreen.kt and 18 more) — HashEngineering
    • dpp (packages/rs-dpp/schema/meta_schemas/document/v3/document-meta.json, packages/rs-dpp/src/address_funds/fee_strategy/mod.rs, packages/rs-dpp/src/address_funds/platform_address.rs and 177 more) — QuantumExplorer or shumkov
    • rs-drive-abci (packages/rs-drive-abci/src/abci/app/check_tx.rs, packages/rs-drive-abci/src/abci/app/consensus.rs, packages/rs-drive-abci/src/abci/app/full.rs and 126 more) — QuantumExplorer or shumkov
    • rs-drive (packages/rs-drive/Cargo.toml, packages/rs-drive/benches/document_average_worst_case.rs, packages/rs-drive/benches/document_count_worst_case.rs and 212 more) — QuantumExplorer or shumkov
    • rs-platform-wallet-ffi (packages/rs-platform-wallet-ffi/src/document.rs, packages/rs-platform-wallet-ffi/src/dpns.rs, packages/rs-platform-wallet-ffi/src/identity_keys_from_mnemonic.rs) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rs-platform-wallet (packages/rs-platform-wallet/PERSISTENCE_REDESIGN.md, packages/rs-platform-wallet/PLAN.md, packages/rs-platform-wallet/docs/DASHPAY_MIGRATION_PLAN.md and 27 more) — HashEngineering or ZocoLini or llbartekll or romchornyi
    • rust-sdk-ffi (packages/rs-sdk-ffi/src/data_contract/mod.rs, packages/rs-sdk-ffi/src/data_contract/property_constraints.rs, packages/rs-sdk-ffi/src/data_contract/put.rs and 30 more) — lklimek or shumkov
    • rust-sdk (packages/rs-sdk/src/platform/contract_moderation.rs, packages/rs-sdk/src/platform/dashpay/contact_request.rs, packages/rs-sdk/src/platform/dashpay/contact_request_queries.rs and 14 more) — lklimek or shumkov
    • swift-sdk (packages/swift-sdk/CLAUDE.md, packages/swift-sdk/Sources/SwiftDashSDK/Core/Utils/DocumentPropertyConstraints.swift, packages/swift-sdk/Sources/SwiftDashSDK/Core/Wallet/WalletStorage.swift and 62 more) — llbartekll or romchornyi

When every box is checked the PR Hygiene check passes and this can merge.

QuantumExplorer and others added 30 commits September 27, 2026 09:32
…eir own round (#5010)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rm (PV14) (#5007)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…in another round (#5028)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…range read (#5030)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (#5031)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…heck (#5032)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ne (PV14) (#5029)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Quantum Explorer <quantum@dash.org>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
… contest holds past 250 (PV14) (#5034)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…V14) (#5036)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s (PV14) (#5037)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…V14) (#5038)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#5040)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…e join price (PV14) (#5039)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ments live in (PV14) (#5033)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…es (PV14) (#5042)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… rules (PV14) (#5045)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…s (PV14) (#5046)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…(PV14) (#5047)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…V14) (#5048)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…act v2 (#5056)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…5051)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…nd iOS example app (#5064)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…and Android example app (#5066)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
infraclaw-dash and others added 21 commits September 28, 2026 20:46
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…test fund (#5163)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…fund options (PV14) (#5158)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…document type (PV14) (#5162)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… write (PV14) (#5161)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…windows (#5170)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ent reveals (PV14) (#5041)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added this to the v4.3.0 milestone Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: dashpay/platform/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: d55db9e3-9ed0-439d-a4cc-3ffde01307b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the waiting-bots Waiting for the review bots to report on this head label Sep 29, 2026
@thepastaclaw

thepastaclaw commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

🕓 Queued for automated review — 11th in line, estimated start in ~1.6 h (commit 3190d4e)
Estimated review time once started: ~1.1 h (two-phase automated review; median of recent runs).

  • Request priority review — click to move this review to the front of the queue.

Resolve the DPNS import block and preserve the previously reviewed PR5151 PV15 query-table compatibility repair. Preserve both source and target ancestry.
@github-actions

Copy link
Copy Markdown
Contributor

🌳 GroveDB structure

This pull request changes the described GroveDB structure. Open it in the structure viewer: new nodes glow, removed ones stay as ghosts, and the tour walks through each change.

Added (5 nodes)

  • pools.lifetime_storage_fee_pools
  • misc.documents_expirations

Changed (13 nodes)

  • pools.pending_epoch_refunds.epoch
  • pools.epoch
  • contracts.contract.documents.document_type.primary_key.document
  • contracts.contract.documents.document_type.index_property
  • contracts.contract.documents.document_type.index_property.value
  • contracts.contract.documents.document_type.index_property.value.members
  • contracts.contract.documents.document_type.index_property.value.members.member
  • contracts.contract.documents.document_type.index_property.value.next_property
  • contracts.contract.other.document_removals
  • contracts.contract.other.document_removals.document_type
  • misc
  • votes.contested_resource.active_polls.contract.document_type.indexes.value
  • votes.contested_resource.active_polls.contract.document_type.indexes.value.next_value

Compared 67340ad824 with 51b781d162. Updated at 2026-09-29T10:04:25.522Z

@github-actions

Copy link
Copy Markdown
Contributor

📖 Book Preview built successfully.

Download the preview from the workflow artifacts.
To view locally: download the artifact, unzip, and open index.html.

Updated at 2026-09-29T10:04:34.963Z

@ktechmidas ktechmidas closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-bots Waiting for the review bots to report on this head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants