Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 10 additions & 17 deletions internal/database/mariadb/autopatch.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,6 @@
return false, err
}

err = s.deleteVersionIssuesOfDisappearedInstances(versionsOfDisappearedInstances)
if err != nil {
return false, err
}

componentsOfDisappearedInstances, err := s.getComponentIdsOfDisappearedInstances(
ctx,
versionsOfDisappearedInstances,
Expand Down Expand Up @@ -273,18 +268,6 @@
return componentIdsOfDisappearedInstances, nil
}

func (s *SqlDatabase) deleteVersionIssuesOfDisappearedInstances(
versionIdsOfDisappearedInstances map[int64]struct{},
) error {
for vIdDi := range versionIdsOfDisappearedInstances {
if err := s.RemoveAllIssuesFromComponentVersion(vIdDi); err != nil {
return err
}
}

return nil
}

func (s *SqlDatabase) deleteVersionsOfDisappearedInstances(
ctx context.Context,
versionIdsOfDisappearedInstances map[int64]struct{},
Expand All @@ -298,9 +281,19 @@
}

if len(res) == 0 {

Check failure on line 284 in internal/database/mariadb/autopatch.go

View workflow job for this annotation

GitHub Actions / golangci-lint

unnecessary whitespace (leading-whitespace) (wsl_v5)
for vIdDi := range versionIdsOfDisappearedInstances {

Check failure on line 286 in internal/database/mariadb/autopatch.go

View workflow job for this annotation

GitHub Actions / golangci-lint

File is not properly formatted (gofumpt)
if err := s.RemoveAllIssuesFromComponentVersion(vIdDi); err != nil {
return err
}

}

if err := s.DeleteComponentVersion(vIdDi, util.SystemUserId); err != nil {
return err
}

Check failure on line 296 in internal/database/mariadb/autopatch.go

View workflow job for this annotation

GitHub Actions / golangci-lint

unnecessary whitespace (trailing-whitespace) (wsl_v5)
}
}

Expand Down
Loading